-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CORS-2386: IBMCloud: Add networkResourceGroupName #6613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Placing on hold as it required the MAPI PR to merge, so we can update go mod with the new changes /hold |
|
Retesting set of failed e2e tests |
|
openshift/machine-api-provider-ibmcloud#12 has merged. |
|
Rebase complete, local testing using the MAPI changes https://amd64.ocp.releases.ci.openshift.org/releasestream/4.13.0-0.ci/release/4.13.0-0.ci-2022-11-30-231313 went well. Ready for review. |
|
Looks like conformance instability |
|
I'll see about rebasing and updating go modules again. |
|
Working on rebasing go mod once again. |
|
I'll rebase and rebuilt the go mod changes again. |
|
/retest |
|
Will attempt to rebuild go modules. |
|
/retest |
|
Looks like I need to rebase go.mod/go.sum again based off the e2e failures, will try that to see if that improves test results. |
|
I rebased and rebuilt go mod changes in hopes that things work properly now |
Added a new installconfig option, networkResourceGroupName, to specify the existing ResourceGroup where existing BYON resources exist. This allows the use to create new cluster resources in new ResourceGroups, or specify the existing ResourceGroup (even the same as network) to create those resources. Related: https://issues.redhat.com/browse/CORS-2386
Update the go mod and vendor packages to pull in the necessary IBM Cloud MAPI changes for NetworkResourceGroupName support.
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/unhold |
rvanderp3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@cjschaef: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This appears to be the same known bug in IBM Cloud, same issue as other PR's (and CI) are suffering |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added a new installconfig option, networkResourceGroupName, to
specify the existing ResourceGroup where existing BYON resources
exist. This allows the use to create new cluster resources in new
ResourceGroups, or specify the existing ResourceGroup (even the
same as network) to create those resources.
Related: https://issues.redhat.com/browse/CORS-2386